Support black preview flag

[mattishallen]

Hi! I use this plugin with neovim's built in LSP and call it from vim.lsp.buf.formatting. The formatting works but it does not respect my black configurations, neither my global config in ~/.config/black nor pyproject.toml in project roots. I also have black installed from pip and there everything works fine.

pyproject.toml:

[tool.black]
line-length = 80
experimental-string-processing = true
target-version = ["py38"]
skip-string-normalization = true

pylsp-black config in init.lua:

    settings = {
      pylsp = {
        plugins = {
          black = {
            enabled = true,
            cache_config = false,
            line_length = 80,
          },

However when I format this code

the underlined error (line length 83 > 80) is not formatted. If i format this using black directly in a shell it is formatted.

[haplo]

Hello @mattishallen, sorry for the late reply.

Can you look at the LSP server's log messages? python-lsp-black has logging about which configuration file is found and used. You might need to increase the logging level of LSP server.

[JesusTorrado]

Hi both,

In case it helps, I am finding a similar issue to @mattishallen's in emacs+eglot. In particular, it is just the preview option that is not applied (in particular the string reflow), while the line length is respected.

My running pylsp configuration is

"pylsp": {
    "plugins": {
      "black": {
        "enabled": true,
        "line_length": 90,  # acknowledged
        "preview": true,  # ignored
        "cache_config": null
      }

A black --preview shell call works as expected.

My black version is 22.10.0 and my python-lsp-black version is 1.2.1.

eglot does not provide access to the LSP logs AFAIK, so not sure whether I can help much with this.

[JesusTorrado]

Maybe setting a preview kwarg is missing in this definition?

python-lsp-black/pylsp_black/plugin.py

Line 85 in c3c0c1d

mode = black.FileMode(

[haplo]

@JesusTorrado Would you mind creating a PR with the fix at https://github.com/JesusTorrado/python-lsp-black/commit/4b8000753c09e55a5c385175e542e686c520a21d?

[JesusTorrado]

Hi @haplo
Not sure I understand what you are asking me to do: there is already a PR at #38

[mahmoudajawad]

@haplo any update on this? Can #38 be merged and a new release be made so we benefit from black preview features?

[haplo]

I apologize for the long delay, I have merged the changes and I'm working towards making a new release with this and other changes.

[mahmoudajawad]

@haplo, no apology needed. Everything you do is much appreciated and I thank you for making it possible for us to use black with lsp.

Keep up the good work!

[haplo]

@haplo, no apology needed. Everything you do is much appreciated and I thank you for making it possible for us to use black with lsp.

Keep up the good work!

Thank you for the kind words. ❤️ The reality is that I used to work daily with Python, so I was an active user. Now I use Python more sporadically for some personal projects, so finding time for maintenance is harder.

In other news: python-lsp-black 1.3.0 is out! 🎉