Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the possibility to configure skip-magic-trailing-comma #37

Merged
merged 2 commits into from
Oct 2, 2022
Merged

Add the possibility to configure skip-magic-trailing-comma #37

merged 2 commits into from
Oct 2, 2022

Conversation

wstevick
Copy link

@wstevick wstevick commented Sep 29, 2022

Fixes #36

their black config file, that will be detected by this.
@ccordoba12 ccordoba12 changed the title Fix https://github.com/python-lsp/python-lsp-black/issues/36#issue-1375072655 Add the possibility to configure skip-magic-trailing-comma Sep 30, 2022
@ccordoba12 ccordoba12 added this to the v1.3.0 milestone Sep 30, 2022
@ccordoba12
Copy link
Member

Thanks for your contribution @wstevick! Our config tests are failing but it shouldn't be that hard to fix them. Let us know if you need help with that.

Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now, thanks @wstevick!

@ccordoba12 ccordoba12 merged commit c3c0c1d into python-lsp:master Oct 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

python-lsp-black ignores skip-magic-trailing-comma in .config/black
2 participants