-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixall should consider range #71
Comments
I'm not sure what kind of range the 'Fix all' action should take, wouldn't you expect it to explicitly go through the whole document instead of only a range? |
I'm not sure what kind of range the 'Fix all' action should take, wouldn't you expect it to explicitly go through the whole document instead of only a range?
as i know generally most lsp server no 'fix all' such thing, but 'all' is about 'range', if 'selected' is different, then 'all' is different.
// at least for now,
// 1. that 'fix all' perhaps actually would do nothing, but stayed in action list still.
// 2. for now, this lsp server did not support code action in range which unlike others.
…--
shane.xb.qian
|
You mentioned that other language servers also include ranges in fix all actions, but I couldn't find any that check in the range only (i.e. ruff-lsp). |
You mentioned that other language servers also include ranges in fix all actions, but I couldn't find any that check in the range only (i.e. [ruff-lsp](https://github.com/astral-sh/ruff-lsp/blob/94577abee37a98c2b571a9ac4f7ec1f167d72dd2/ruff_lsp/server.py#L859C5-L890)).
i did not mean 'ruff' or 'python' lsp, this one is the only one i can find had 'fix all' action in the list.
Otherwise I would be opposed to this, since the "Fix all" action is supposed to just go through the document and apply any easy applicable fixes without any user input required.
ok, understand, besides as i said in #72, i have no idea why that 2 issues happened, not sure if was me made it or was existed, but current 'fix all' would cover it.
…--
shane.xb.qian
|
'fix all' of code action should consider the range,
the statement in
def pylsp_code_actions(
:should be not true, this range i guess should be used later in
checks_with_fixes
to filter fixes only in this range.otherwise 'fix all' probably in the action list all the time, but that actually maybe would get action nothing from it.
The text was updated successfully, but these errors were encountered: