Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix code action range #72

Closed

Conversation

Shane-XB-Qian
Copy link
Contributor

take account 'range' to 'code action', i think it is a general spec way.

closes #71

Signed-off-by: shane.xb.qian <shane.qian@foxmail.com>
Signed-off-by: shane.xb.qian <shane.qian@foxmail.com>
Signed-off-by: shane.xb.qian <shane.qian@foxmail.com>
Signed-off-by: shane.xb.qian <shane.qian@foxmail.com>
Signed-off-by: shane.xb.qian <shane.qian@foxmail.com>
Signed-off-by: shane.xb.qian <shane.qian@foxmail.com>
Signed-off-by: shane.xb.qian <shane.qian@foxmail.com>
@Shane-XB-Qian
Copy link
Contributor Author

my PR should be mostly working, but i noticed there are 2 issues in following example:

  1. the last line, the 'a', it is a 'unsafe' fix, but not sure why it listed in 'fix all';
  2. if chose to apply this 'fix all' at that, the range seems was incorrect.

i donot know if it was me made it, or it was a known/existed bug,
@jhossbach not sure if you'd like this proposal also, if not, then let it be,
// if so, 'fix all' always be there, and seems following 2 issues would be covered also.

import os

b = c

def f():
    a = 2

@Shane-XB-Qian Shane-XB-Qian deleted the fix_code_action_range branch December 28, 2023 13:29
@Shane-XB-Qian Shane-XB-Qian mentioned this pull request Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fixall should consider range
1 participant