Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make including unsafe fixes among code actions the default #82

Closed
wants to merge 1 commit into from
Closed

Conversation

JohnADawson
Copy link

@JohnADawson JohnADawson commented Feb 12, 2024

It is convenient to include unsafe fixes among code actions. Because they are marked (unsafe) and including them does not affect the action Fix All, there is little reason not to. Herefor, this behaviour ought to be the default.

It is convenient to include unsafe fixes among code actions. Because they are
marked `(unsafe)` and including them does not affect the action `Fix All`, there
is little reason not to. Herefor, this behaviour ought to be the default.
@jhossbach
Copy link
Member

I want to keep close to the default to ruff, trying to avoid "surprises", basically: the LSP should work as if I ran ruff in the terminal. Since --unsafe-fixes is not the default, I would be unhappy to see it if I didn't explicitly enable it via the config.

@jhossbach jhossbach closed this Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants