-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI Review #3606
Comments
It's definitely worth looking into. Building Windows binaries would definitely be great. More info from GitHub: https://github.blog/2018-09-10-azure-pipelines-now-available-in-github-marketplace/ I've seen a few other projects move over to Azure Pipelines, but haven't looked into it much. It can do Linux, Windows and macOS, and CPython, pip and NumPy are testing those with Azure. I think our current CI system is doing quite a good job, it'd be nice for all three platforms to be tested in one place, and especially if Azure is faster (with 10 parallel builds). Right now:
From a NumPy discussion:
What are our long term goals?
|
I had a play with Azure Pipelines yesterday, adding it to another pure Python (with no C) project. Some notes.
As the serial one-worker builds of Appveyor are so slow, the biggest benefit for us would be to get Windows builds onto Azure. There's nothing to stop us having more than one CI running, especially whilst trying things out. Pip are still using Travis, Appveyor and Azure, with the first two marked as "required" for PRs. |
See #3670 for a first step to get the plumbing installed. |
#3670 is merged to add config to the repo. I've created an org and project at https://dev.azure.com/python-pillow/pillow/ @python-pillow/pillow-team I'll add you as admins, please let me know your Azure (https://azure.microsoft.com) sign-in address or display name (either here or privately via https://github.com/orgs/python-pillow/teams/pillow-team or email). |
Weee thanks @hugovk. Looks like I'm aclark4life@hotmail.com. |
@aclark4life Added! Please could you add a new CI "pipeline"? Something like this:
|
Thanks, it's working! I rebased PR #3661 to test automated builds, and that's working too: https://dev.azure.com/python-pillow/pillow/_build/results?buildId=2 |
In the time it took for 12 Azure jobs to finish (5m 43s), 6 Travis jobs finished (full build 21m 29s), and the first AppVeyor job was still going (full build ~63m). TODO:
|
Do we have a way to skip Azure builds per commit? |
We can now skip Azure Pipelines builds using any of these:
Re: microsoft/azure-pipelines-agent#1270 (comment) BUT for some reason Microsoft decided to ignore it on what they call "PR builds", and only honour it for what they call "CI builds". They've decided they know better and that builds will be run for PRs even when we specifically add Re: microsoft/azure-pipelines-agent#1270 (comment) We need to suggest they make it consistent with Travis, AppVeyor, etc.:
|
@aclark4life Please could you put It looks good, very similar to Azure Pipelines for CI with a huge 20 parallel build jobs (compared to AP's 10, Travis 5, AppVeyor 1). |
@hugovk, I just pushed the button for the beta. I’m kind of excited to get this set up on a day job repo to see how it goes, we’ll see who gets it first. |
Thanks! It took 6 months for my account to be approved, but hopefully it won't be so long for new signups, as they're launching in November. Good luck setting up the day job repo, have a look at hugovk/pypistats#70 for tips. |
Just got notification that my account is in the beta, so I’m pretty sure that means that it’s setup on this org. Let me know if there’s something else that needs to be done.
…Sent from my iPhone
On 23 Aug 2019, at 9:29 a.m., Hugo van Kemenade ***@***.***> wrote:
Thanks!
It took 6 months for my account to be approved, but hopefully it won't be so long for new signups, as they're launching in November.
Good luck setting up the day job repo, have a look at hugovk/pypistats#70 for tips.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Looks like it's not enabled yet for this org, there's no GitHub Actions showing for #4058: On my account, I see this: I think you need to request access separately for each user and organisation from the dropdown at https://github.com/features/actions/signup/?account=python-pillow. |
GitHub Actions is enabled, here's some PRs to replicate the Travis builds:
|
Discussion about Travis CI continued in #5028. |
I just heard about Oregon State University's Open Source Lab, they offer services for open-source projects, perhaps something here could help replace the unique CPUs from Travis? |
@hugovk What do we need? I worked with them a while back on some @plone infrastructure but I don't remember exactly how it turned out, aside from @plone was paying for some of it and didn't want to spend as much as I wanted OSU to buy 😄 In any event, if you want to summarize I'll submit a request here: https://osuosl.org/request-hosting/ |
Just to state it in this issue - if Travis CI ever does run out of credits, python-pillow/pillow-wheels#247 can be used to move the aarch64 jobs to GitHub Actions, albeit with a much longer execution time. |
Pillow 9.3.0 has just been released - the first release with Windows wheels generated by our CIs. |
With the news that travis has been acquired, I've seen a bunch of discussion about CI platforms, leading to some questions:
One of the goals that I had originally with Appveyor was to be able to produce our windows binaries off of a CI system, rather than bothering @cgohlke for them every single time, as he's a single point of failure for the entire windows python ecosystem. I'm not sure where we are on the windows testing WRT external dependency completeness or python version coverage. Azure pipelines has now introduced free build time for open source projects, and I believe that the python core is now on that for their packages. I believe that they also do linux builds, but not macos. It may be worth investigating if their environment is any easier to get all the dependencies to build.
The text was updated successfully, but these errors were encountered: