Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Azure Pipelines CI #3670

Merged
merged 6 commits into from
Mar 6, 2019
Merged

Add Azure Pipelines CI #3670

merged 6 commits into from
Mar 6, 2019

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Feb 21, 2019

For #3606.

Changes proposed in this pull request:

TODO:

@hugovk hugovk mentioned this pull request Feb 21, 2019
@hugovk
Copy link
Member Author

hugovk commented Feb 24, 2019

Updated to move the 11 Docker builds from Travis CI to Azure Pipelines.

It was quite straightforward to move this over, which of course is the whole point of Docker!

  • The Azure Pipelines build takes 5-6 minutes for the 1+11 jobs.

  • The Travis CI build goes from ~26 minutes for 24 jobs to ~13 minutes for 13 jobs.

And both CIs run in parallel, meaning all these Linux builds are now done in max(6, 13) == 13 minutes.

Notes:

Uses templates for the build matrix by passing in parameters:

- template: .azure-pipelines/jobs/test-docker.yml
  parameters:
    docker: 'ubuntu-trusty-x86'
    name:   'ubuntu_trusty_x86'
  • docker is the Docker image pulled from the pythonpillow Docker Hub.
  • name is the display name of the job, A-Z, a-z, 0-9, and underscore
    • Duplicates docker, but with dashes replaced with underscores
  • dockerTag can be specified as well, but defaults to master
  • vmImage is the base image used for running Docker on. Defaults Ubuntu-16.04, the most recent Ubuntu available

https://docs.microsoft.com/en-us/azure/devops/pipelines/yaml-schema?view=azure-devops&tabs=schema#job

TODO later:

  • Also run .travis/after_success.sh for Azure Dockers to send coverage to Codecov

See also https://twitter.com/ReinH/status/1098663375985229825

@hugovk
Copy link
Member Author

hugovk commented Mar 5, 2019

I had a go getting coverage working on Azure Pipelines in another branch but got a bit stuck getting all the pieces in place (problems with permissions creating coverage output with lcov and coveralls), so I've reverted the last commit ("Remove Docker builds from Travis CI").

Let's merge this then enable AP for the repo. We can't remove builds from Travis until coverage is sorted, but we will benefit from seeing build results sooner and learning how AP works.

@hugovk hugovk merged commit 8194677 into python-pillow:master Mar 6, 2019
@hugovk hugovk deleted the add-azure branch March 6, 2019 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant