Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up resampling a bit again #2680

Merged
merged 1 commit into from
Aug 16, 2017
Merged

Conversation

homm
Copy link
Member

@homm homm commented Aug 12, 2017

Not a big deal, but why not )

Scale 2560×1600 RGB image
    to 2048x1280 bil    71.30 Mpx/s    77.93 Mpx/s
    to 2048x1280 bic    50.37 Mpx/s    54.74 Mpx/s
    to 2048x1280 lzs    37.40 Mpx/s    39.01 Mpx/s
    to 5478x3424 bil    15.03 Mpx/s    16.56 Mpx/s
    to 5478x3424 bic    11.63 Mpx/s    12.50 Mpx/s
    to 5478x3424 lzs     9.27 Mpx/s     9.84 Mpx/s

@homm
Copy link
Member Author

homm commented Aug 15, 2017

Absolute coverage decreased by -0.01% but relative coverage increased by +18.31% compared to bbe07d4

Looks like codecov is smarter than coveralls

#define MAKE_UINT32(u0, u1, u2, u3) (u3 | (u2<<8) | (u1<<16) | (u0<<24))
#else
#define MAKE_UINT32(u0, u1, u2, u3) (u0 | (u1<<8) | (u2<<16) | (u3<<24))
#endif
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wiredfool if you have a couple of minutes, I'd like to ask you to look at this macros at first. The same macros are used in many recent PR's. I'm not very familiar with endings.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I've fired up the antique bigendian PPC machine I have here, and the only failures I'm seeing are with 16bit jpeg2k files, but those tests appear to fail all the way back.

These macros appear to be fine, assuming that we've got enough testing on this part.

@homm homm merged commit c40884c into python-pillow:master Aug 16, 2017
@homm homm deleted the fast-resample branch August 16, 2017 10:39
@homm homm mentioned this pull request Aug 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants