Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fast unpacking and partially packing #2693

Merged
merged 14 commits into from
Aug 31, 2017

Conversation

homm
Copy link
Member

@homm homm commented Aug 21, 2017

Benchmarks:

                     Master           This branch
Unpack from L       4697.80 Mpx/s    4745.82 Mpx/s  # No changes
Unpack from LA       615.37 Mpx/s     782.75 Mpx/s
Unpack from RGB      571.12 Mpx/s    1419.82 Mpx/s
Unpack from RGBA    1373.62 Mpx/s    1390.41 Mpx/s  # No changes
Pack to L           2406.48 Mpx/s    2494.54 Mpx/s  # No changes
Pack to LA           727.90 Mpx/s     730.90 Mpx/s  # No changes
Pack to RGB          524.85 Mpx/s     777.51 Mpx/s
Pack to RGBA         669.26 Mpx/s     660.43 Mpx/s  # No changes

@wiredfool
Copy link
Member

FWIW, this does pass all the tests on PPC/big endian.

@homm
Copy link
Member Author

homm commented Aug 22, 2017

Should be rebased after #2694 merge

# Conflicts:
#	Tests/test_lib_pack.py
@homm homm removed the Needs Tests label Aug 26, 2017
@homm
Copy link
Member Author

homm commented Aug 26, 2017

Merged tests from #2694 there.

@homm homm removed the Do Not Merge label Aug 27, 2017
@homm homm changed the title [WIP] Fast unpacking and partially packing Fast unpacking and partially packing Aug 27, 2017
@homm
Copy link
Member Author

homm commented Aug 28, 2017

Coverage reduced because number of lines in Unpack.c is reduced.

@wiredfool wiredfool merged commit 367ce3c into python-pillow:master Aug 31, 2017
@homm homm deleted the fast-unpacking branch August 31, 2017 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants