Warnings if imaging library has wrong UCS support. #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Raise exceptions for unknown errors.
|
Please carefully review the pull request. I'm not familiar with the intrinsics of Pillow (heck, the fact that I used a different Python (--without-wide-unicode) to build & install Pillow than the one to run Pillow (---with-wide-unicode) is already a give-away that I'm perfectly able to screw things up ;) |
|
@macfreek Thanks! We'll take a look |
|
I think we can go farther... I'll have an updated pull request. |
|
Thanks @wiredfool |
radarhere
added a commit
to radarhere/Pillow
that referenced
this pull request
Sep 24, 2023
Updated auditwheel to include auditwheel#376
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #297.
Please note that this fix raises the original exception when an unknown error occurs. An alternative is to also call warnings.warn(str(v)) for unknown errors.