LCMS1 replaced with LCMS2 #380
Conversation
wiredfool
commented
Oct 16, 2013
wiredfool
commented
- Adds support for LCMS2, fixes Drop support for LCMS version 1 #343.
- Removes support for LCMS1 (security)
- Includes revised support for LAB color mode
- Conversions to and from LAB color using LCMS2 work.
- Reading/writing LAB color space tiffs works.
- Internal representation of LAB color mode a and b channels has changed to 0-255, 128 is neutral.
…mplicated sfuff that's not easily exposed in lcms2
…igned int on pack
|
Wow nice, safe to merge this or you want some folks to review? |
|
Probably safe. As much as I'd like a review, the most useful review would come from people using lcms. I'm not too worried about the individual code bits. There are a couple edge cases where someone could have possibly used LAB before, and that was pulling in from 2 or 3 file formats. The a and b channels will change from that, but that's probably safe to break. I'm pretty sure that the LAB color support with LCMS1 was broken, so converting to and from the old lab would have been impossible anyway. Oh, and some of the text descriptions from the profiles changed. |
|
Yep and that person was on IRC and I can't recall who it was, nor do I have any contact info, so I'm going to merge this. Thanks |
|
I think it was curmudgeon. But I haven't seen him again. And I don't think that it's the curmudgeon on github. |
