Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added three new channel operations #4230

Merged
merged 11 commits into from
Mar 31, 2020
Merged

Added three new channel operations #4230

merged 11 commits into from
Mar 31, 2020

Conversation

dwastberg
Copy link
Contributor

Add the channel operations Soft Light, Hard Light and Overlay, using the algorithms defined here: http://www.pegtop.net/delphi/articles/blendmodes/

hugovk
hugovk reviewed Dec 22, 2019
View reviewed changes
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use snake case soft_light and hard_light instead of softlight and hardlight.

src/libImaging/Chops.c Outdated Show resolved Hide resolved
@radarhere radarhere mentioned this pull request Dec 25, 2019
Closed
@python-pillow python-pillow deleted a comment from codecov bot Feb 19, 2020
@python-pillow python-pillow deleted a comment from codecov bot Feb 19, 2020
@python-pillow python-pillow deleted a comment from codecov bot Feb 19, 2020
@python-pillow python-pillow deleted a comment from codecov bot Feb 19, 2020
@hugovk hugovk merged commit c6115c1 into python-pillow:master Mar 31, 2020
@hugovk hugovk mentioned this pull request Mar 31, 2020
Closed
23 tasks
@hugovk
Copy link
Member

hugovk commented Mar 31, 2020

Thanks!

@radarhere radarhere mentioned this pull request Mar 31, 2020
Merged
@dwastberg dwastberg deleted the new_chops branch May 5, 2020 12:32
@StatusWrike StatusWrike mentioned this pull request Nov 9, 2020
Closed
@sync-by-unito sync-by-unito bot mentioned this pull request Feb 1, 2021
Closed
This was referenced Mar 6, 2021
Merged
Open
This was referenced Mar 17, 2021
Closed
Closed
Merged
Closed
Merged
Closed
Merged
Merged
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Merged
Closed
Closed
Closed
Open
Closed
Closed
Closed
Closed
Closed
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugovk hugovk hugovk left review comments

Assignees
No one assigned
Labels
Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dwastberg @hugovk @radarhere