-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add JPEG comment to info dictionary #4455
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The other two have comment
in the docs:
- https://pillow.readthedocs.io/en/stable/handbook/image-file-formats.html#gif
- https://pillow.readthedocs.io/en/stable/handbook/image-file-formats.html#gbr
Let's also add for JPEG:
And perhaps release notes?
@@ -298,6 +298,9 @@ The :py:meth:`~PIL.Image.Image.open` method may set the following | |||
**exif** | |||
Raw EXIF data from the image. | |||
|
|||
**comment** | |||
A comment about the image. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we have a "New in version 7.1.0."?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call. Done
The MinGW download failures look like this:
msys2/MSYS2-packages#1884 (comment) Possible workaround here: msys2/MINGW-packages#6256 (comment), but we can probably wait a bit. Anyway, unrelated to this PR, and it passed earlier, and only docs changes were made since if failed. |
Looks like the repo.msys2.org server is back up: I restarted the failed job and it passed: |
Resolves #4450
Adds JPEG comment to the
info
dictionary, in the same way that GIF and GBR do.