Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release Python GIL when converting images using matrix operations #6418

Merged
merged 1 commit into from
Oct 25, 2022
Merged

Release Python GIL when converting images using matrix operations #6418

merged 1 commit into from
Oct 25, 2022

Conversation

hmaarrfk
Copy link
Contributor

@hmaarrfk hmaarrfk commented Jul 5, 2022 •
edited by radarhere
Loading

Resolves #6520

Related to

Changes proposed in this pull request:

  • Release python GIL when converting images using matrix operations

Thank you for reviewing!

@radarhere radarhere changed the title Release python GIL when converting images using matrix operations Release Python GIL when converting images using matrix operations Jul 5, 2022
@hmaarrfk
Copy link
Contributor Author

hmaarrfk commented Jul 13, 2022 •
edited by radarhere
Loading

kind bump

@hmaarrfk
Copy link
Contributor Author

Gentle bump in case anybody wanted to review this. It would be greatly appreciated.

@hmaarrfk hmaarrfk mentioned this pull request Aug 22, 2022
Closed
hugovk
hugovk approved these changes Oct 12, 2022
View reviewed changes
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@hmaarrfk
Copy link
Contributor Author

Thank you for including tests for error cases. This made finding bugs in my original implementation easy!

@hugovk hugovk merged commit 9bbf56b into python-pillow:main Oct 25, 2022
@hmaarrfk
Copy link
Contributor Author

Thanks!

@hugovk hugovk mentioned this pull request Oct 28, 2022
Merged
@sync-by-unito sync-by-unito bot mentioned this pull request Aug 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugovk hugovk hugovk approved these changes

Assignees
No one assigned
Labels
Performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Releasing the GIL during matrix image conversion
2 participants
@hmaarrfk @hugovk