Added direct conversion from PA to P #6509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radarhere
commented
Aug 16, 2022
| @@ -1209,6 +1217,8 @@ frompalette(Imaging imOut, Imaging imIn, const char *mode) { | |||
| convert = alpha ? pa2l : p2l; | |||
| } else if (strcmp(mode, "LA") == 0) { | |||
| convert = alpha ? pa2la : p2la; | |||
| } else if (strcmp(mode, "P") == 0) { | |||
| convert = pa2p; | |||
There was a problem hiding this comment.
Strange that Codecov doesn't think this is tested - when I run the test suite on my local machine, it is tested by test_image_convert.py's test_sanity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6506 asked how Pillow converted images from PA to P.
The answer was because PA to P conversion doesn't exist, Pillow instead falls back to converting from PA to RGB, and then RGB to P.
This PR adds direct conversion from PA to P. There should be no functional change, only an increase in efficiency.