Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not attempt to install cmake a second time when building macOS or Linux wheels #8566

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

radarhere
Copy link
Member

#8497 added

# Ensure cmake is available
python3 -m pip install cmake

to the macOS and Linux wheels.

However, we still have an alternative attempt to install cmake.

function build_brotli {
if [ -e brotli-stamp ]; then return; fi
local cmake=$(get_modern_cmake)
local out_dir=$(fetch_unpack https://github.com/google/brotli/archive/v$BROTLI_VERSION.tar.gz brotli-$BROTLI_VERSION.tar.gz)
(cd $out_dir \
&& $cmake -DCMAKE_INSTALL_PREFIX=$BUILD_PREFIX -DCMAKE_INSTALL_LIBDIR=$BUILD_PREFIX/lib -DCMAKE_INSTALL_NAME_DIR=$BUILD_PREFIX/lib . \

where get_modern_cmake is from multibuild.

That can now be removed.

@hugovk hugovk merged commit 4304414 into python-pillow:main Nov 25, 2024
25 checks passed
@radarhere radarhere deleted the cmake_wheel branch November 25, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants