Migrate builds to GHA #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
For reference, example builds:
@wiredfool Please could you review and add the credentials as secrets? |
nulano
commented
Nov 4, 2020
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
|
As a test/demonstration, I have also pushed the built images to my Docker account and tested here: https://github.com/nulano/Pillow/actions/runs/346068049/workflow#L44 |
|
Let's merge and add credentials later. Thanks! |
|
Sorry, this disappeared into my backlog, I’ll try to dig out the creds. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #68
For python-pillow/Pillow#5028
The script is almost an exact copy from Travis, except updated to GHA syntax; there is just one small change due to file permissions:
sudo chmod a+w .added at the start of the build and thesudo chowncommand moved later.Docker login details need to be stored as a Github Secret in
DOCKER_USERNAMEandDOCKER_PASSWORD.