This repository has been archived by the owner on Oct 8, 2024. It is now read-only.
Disable SSE4.1 for libwebp to update travis osx_image to 9.4 #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 16, 2018
Merged
hugovk
reviewed
Sep 23, 2018
config.sh
Outdated
| if [ -n "$IS_OSX" ]; then | ||
| # Custom libwebp build |
There was a problem hiding this comment.
Shall we comment here why this is a custom build?
ie. disabling SSE4.1 to be able to target 10.10
So if we want to target a newer version in the future, we know we can revert it.
radarhere
changed the title
|
#104 is merged, closing this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #96. Alternative to #104
The custom
build_libwebpis customised from https://github.com/matthew-brett/multibuild/blob/6713093b24c014168d282df1111ed6cdc141da55/library_builders.sh#L198, removing the libraries already built, and adding--disable-sse4.1