fix: avoid zerodivisionerrors in no-tty usecase #298
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for python-poetry/poetry#7184, which discovered that this would lead to ZeroDivisionErrors as `columns` will be `0` for Python <3.11 running without a TTY.
4 tasks
|
A Cleo maintainer is working on a better fix with test coverage, so this will likely be declined. However, feel free to leave it open until a successor materializes. |
|
Superseded by #299 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for python-poetry/poetry#7184, which discovered that this would
lead to ZeroDivisionErrors as
columnswill be0for Python <3.11running without a TTY.