Print correct final MSStore Python bin dirs after install #86
Conversation
The installer class still had the unresolved, old bin dirs before being resolved. So they were incorrectly being printed at the end of the install.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This is a follow up to #18 and python-poetry/poetry#5931. I am on Windows with Git Bash, using the Microsoft Store Python. The installer script correctly installs Poetry into the sandboxed location provided by the MSStore Python. However, the final message printed to the user by the install script is wrong. It uses the old, unresolved bin path, which points to nothing. My fix is to pass back the env object's bin dir to the installer object, and if it is different than the installer object's bin dir, then assume it was resolved to something else and print that. I just hacked something together as a starting point. It does the job, but should be iterated on. |
|
This is not mergable -- we don't want to hardcode Windows assumptions like this (and indeed, the "fix" from #18 actually should be partially reverted as it breaks some scenarios). I've got a branch locally which solves some of these issues, I'll try to dust it off in the next few days. |
|
@neersighted sorry to bother you, but is there a chance we can get your local branch upstream soon? |
|
This issue still remains in August 2023. No progress here? This wrong message in the console really makes a whole lot of confusion. |
|
Just ran into this as well. The current situation is considerably confusing, as the installation instructions at https://python-poetry.org/docs/ explicitly mention Python from the Windows Store, implicitly suggesting to the user that it is supported. Yet, after following the on-screen instructions, |
|
Agreed, at least we should mention that MS Store Python is not supported |
The installer class still had the unresolved, old bin dirs before being resolved. So they were incorrectly being printed at the end of the install.