add comment that attributes must be immutable

src/poetry/core/packages/dependency.py

@@ -62,6 +62,9 @@ def __init__(
             features=extras,
         )
 
+        # Attributes must be immutable for clone() to be safe!
+        # (For performance reasons, clone only creates a copy instead of a deep copy).
+
         self._constraint: VersionConstraint
         self._pretty_constraint: str
         self.constraint = constraint  # type: ignore[assignment]

src/poetry/core/packages/directory_dependency.py

@@ -34,6 +34,8 @@ def __init__(
             base=base,
             extras=extras,
         )
+        # Attributes must be immutable for clone() to be safe!
+        # (For performance reasons, clone only creates a copy instead of a deep copy).
         self._develop = develop
 
         # cache this function to avoid multiple IO reads and parsing

src/poetry/core/packages/file_dependency.py

@@ -36,6 +36,8 @@ def __init__(
             subdirectory=directory,
             extras=extras,
         )
+        # Attributes must be immutable for clone() to be safe!
+        # (For performance reasons, clone only creates a copy instead of a deep copy).
 
     @property
     def directory(self) -> str | None:

src/poetry/core/packages/package.py

@@ -94,6 +94,9 @@ def __init__(
             features=features,
         )
 
+        # Attributes must be immutable for clone() to be safe!
+        # (For performance reasons, clone only creates a copy instead of a deep copy).
+
         self._set_version(version)
 
         self.description = ""

src/poetry/core/packages/path_dependency.py

@@ -32,6 +32,8 @@ def __init__(
         subdirectory: str | None = None,
         extras: Iterable[str] | None = None,
     ) -> None:
+        # Attributes must be immutable for clone() to be safe!
+        # (For performance reasons, clone only creates a copy instead of a deep copy).
         assert source_type in ("file", "directory")
         self._path = path
         self._base = base or Path.cwd()

src/poetry/core/packages/project_package.py

@@ -36,6 +36,9 @@ def __init__(
 
         super().__init__(name, version)
 
+        # Attributes must be immutable for clone() to be safe!
+        # (For performance reasons, clone only creates a copy instead of a deep copy).
+
         self.build_config: Mapping[str, Any] = {}
         self.packages: Sequence[Mapping[str, Any]] = []
         self.include: Sequence[Mapping[str, Any]] = []

src/poetry/core/packages/specification.py

@@ -29,6 +29,9 @@ def __init__(
     ) -> None:
         from packaging.utils import canonicalize_name
 
+        # Attributes must be immutable for clone() to be safe!
+        # (For performance reasons, clone only creates a copy instead of a deep copy).
+
         self._pretty_name = name
         self._name = canonicalize_name(name)
         self._source_type = source_type

src/poetry/core/packages/url_dependency.py

@@ -21,6 +21,8 @@ def __init__(
         optional: bool = False,
         extras: Iterable[str] | None = None,
     ) -> None:
+        # Attributes must be immutable for clone() to be safe!
+        # (For performance reasons, clone only creates a copy instead of a deep copy).
         self._url = url
         self._directory = directory
 

src/poetry/core/packages/vcs_dependency.py

@@ -29,6 +29,8 @@ def __init__(
         develop: bool = False,
         extras: Iterable[str] | None = None,
     ) -> None:
+        # Attributes must be immutable for clone() to be safe!
+        # (For performance reasons, clone only creates a copy instead of a deep copy).
         self._vcs = vcs
         self._source = source