Skip to content

Commit

Permalink
package: do not default to develop
Browse files Browse the repository at this point in the history
Setting develop to `True` by default causes un-expected side-effects
and requires downstream consumers to rely on checks like
`package.develop and package.source_type == "directory""` to determine
if develop mode.

This also corresponds to current high-level behaviour of packages being
non-develop by default.
  • Loading branch information
abn committed Mar 12, 2021
1 parent 9a8cd00 commit 5d5251c
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions poetry/core/packages/package.py
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,8 @@ def __init__(
source_url: Optional[str] = None,
source_reference: Optional[str] = None,
source_resolved_reference: Optional[str] = None,
features: Optional[List[str]] = None, # type
features: Optional[List[str]] = None,
develop: bool = False,
) -> None:
"""
Creates a new in memory package.
Expand Down Expand Up @@ -105,7 +106,7 @@ def __init__(

self.root_dir = None

self.develop = True
self.develop = develop

@property
def name(self) -> str:
Expand Down

0 comments on commit 5d5251c

Please sign in to comment.