Keep _constraint and _pretty_constraint of Dependency synchronized wh…

…en calling set_constraint() (#214)
python-poetry · Nov 21, 2021 · af08f1c · af08f1c
1 parent 6215dd1
commit af08f1c
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/src/poetry/core/packages/dependency.py b/src/poetry/core/packages/dependency.py
@@ -56,9 +56,9 @@ def __init__(
         )
 
         self._constraint = None
+        self._pretty_constraint = None
         self.set_constraint(constraint=constraint)
 
-        self._pretty_constraint = str(constraint)
         self._optional = optional
 
         if not groups:
@@ -109,6 +109,7 @@ def set_constraint(self, constraint: Union[str, "VersionTypes"]) -> None:
                 self._constraint = constraint
         except ValueError:
             self._constraint = parse_constraint("*")
+        self._pretty_constraint = str(constraint)
 
     @property
     def pretty_constraint(self) -> str:

diff --git a/tests/packages/test_dependency.py b/tests/packages/test_dependency.py
@@ -250,6 +250,13 @@ def test_dependency_string_representation(
     assert str(dependency) == expected
 
 
+def test_set_constraint_sets_pretty_constraint():
+    dependency = Dependency("A", "^1.0")
+    assert dependency.pretty_constraint == "^1.0"
+    dependency.set_constraint("^2.0")
+    assert dependency.pretty_constraint == "^2.0"
+
+
 def test_with_constraint():
     dependency = Dependency(
         "foo",