Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename implicit group "default" to "main" #326

Merged
merged 1 commit into from
Apr 25, 2022

Conversation

radoering
Copy link
Member

@radoering radoering commented Apr 17, 2022

This is done in order to avoid ambiguity between "default group" and "default dependencies" (the groups that are considered by a command by default)

Has to be considered together with python-poetry/poetry#5465 and python-poetry/poetry-plugin-export#52

In order to allow the downstream tests to pass, python-poetry/poetry#5465 has to be merged first.

@radoering radoering force-pushed the rename-group-default-to-main branch from 576e176 to b481fe8 Compare April 18, 2022 05:09
@radoering radoering requested a review from a team April 24, 2022 15:32
This is done in order to avoid ambiguity between "default group" and "default dependencies" (the groups that are considered by a command by default)
@radoering radoering force-pushed the rename-group-default-to-main branch from b481fe8 to 47c9971 Compare April 25, 2022 15:47
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.7% 1.7% Duplication

@abn abn merged commit 524de0b into python-poetry:master Apr 25, 2022
@finswimmer finswimmer mentioned this pull request May 20, 2022
@radoering radoering deleted the rename-group-default-to-main branch November 24, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants