Do not consider constraints when checking for equality of direct origi… #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jinior
changed the title
Closed
1 task
|
Can somebody re-run the pipeline on this PR? I suspect it failed due to #406 |
Jinior
force-pushed
the
fix-dependency-eq
branch
from
63681df to
d4d8727
Compare
radoering
force-pushed
the
fix-dependency-eq
branch
from
be2e69a to
3137990
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
radoering
approved these changes
Jul 3, 2022
Merged
bostonrwalker
pushed a commit
to bostonrwalker/poetry-core
that referenced
this pull request
Aug 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…n dependencies
Resolves: python-poetry/poetry#5902 and partially python-poetry/poetry#2415
An alternative solution to python-poetry/poetry#5902 as proposed in python-poetry/poetry#5903.
Currently poetry re-downloads direct origin packages multiple times during locking because the deferred cache used to store downloaded packages is indexed using a dependency object with an explicit constraint while the lookup is done with a dependency object with an unbounded constraint which do not test equal.
This PR solves that issue by changing the
__eq__equality check for direct origin dependencies to not consider the constraint. This should pose no problems since direct origin dependencies pointing to the same origin implicitly have the same constraint.Should I add a test for this or do we consider this an implementation detail for the sake of our current caching mechanism?