Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parsing of git urls with egg before subdirectory #518

Merged
merged 2 commits into from
Jan 7, 2023

Conversation

apage224
Copy link
Contributor

@apage224 apage224 commented Nov 7, 2022

This PR addresses an issue with parsing git based dependencies. A VCS git dependency may optionally specify tag, egg, and subdirectory attributes. Due to the ordering of regex matching, some of these attributes would be silently ignored. For example, git+ssh://git@git.example.com:sdispater/project/my_repo.git@commit#egg=package&subdirectory=project_dir would properly extract tag as commit but subdirectory would be None. The unit tests already includes these edge case URLs, however, egg name and subdirectory were not being checked. Unit test has been updated to verify subdirectory matches.

@sonarcloud
Copy link

sonarcloud bot commented Nov 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@radoering radoering changed the title Fix vcs git regex order Fix parsing of git urls with egg before subdirectory Jan 7, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jan 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
5.7% 5.7% Duplication

@radoering radoering merged commit 78f57f7 into python-poetry:main Jan 7, 2023
@radoering radoering mentioned this pull request Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants