fix --with-credentials export of --extra-index-url lines #117
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #22.
The fix for this issue is to add a single character:
indexes_header = ...
becomesindexes_header += ...
within the loop that builds the--index-url
and--extra-index-url
lines of the exported text.I added a test case to demonstrate the problem and prove to myself that I'd fixed it.
I had to run
poetry lock
to bump the poetry dependency to 1.2.0. The previously locked version, 1.2.0b3, didn't actually remove the PyPI repository frompoetry.pool
when my new test calledpoetry.pool.remove_repository("PyPI")
. The implementation of that method changed from 1.2.0b3 to 1.2.0 to address exactly that issue. If it's possible to add a different default repository with 1.2.0b3, I'm happy to revert thepoetry lock
commit and modify the test case.