Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed testcase exporting extras #66

Merged
merged 1 commit into from
May 26, 2022
Merged

fixed testcase exporting extras #66

merged 1 commit into from
May 26, 2022

Conversation

dimbleby
Copy link
Contributor

If python-poetry/poetry#5688 is merged, the new behaviour will be per this updated testcase.

I don't think that either this or that MR can be merged before the other without there being some intermediate breakage of tests.

@dimbleby dimbleby mentioned this pull request May 25, 2022
Merged
@sonarcloud
Copy link

sonarcloud bot commented May 25, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dimbleby
Copy link
Contributor Author

dimbleby commented May 25, 2022 •
edited
Loading

(commented in wrong MR, now moved)

@abn abn merged commit b7e5521 into python-poetry:main May 26, 2022
@dimbleby dimbleby deleted the fixed-export-extras-test branch May 26, 2022 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abn abn abn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dimbleby @abn