Skip to content

Commit

Permalink
refactor: Pool should not inherit from Repository
Browse files Browse the repository at this point in the history
  • Loading branch information
b-kamphorst authored and neersighted committed Oct 10, 2022
1 parent 6ae4855 commit 2d2ee7e
Showing 1 changed file with 8 additions and 6 deletions.
14 changes: 8 additions & 6 deletions src/poetry/repositories/pool.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,22 +3,23 @@
from typing import TYPE_CHECKING

from poetry.repositories.exceptions import PackageNotFound
from poetry.repositories.repository import Repository


if TYPE_CHECKING:
from poetry.core.constraints.version import Version
from poetry.core.packages.dependency import Dependency
from poetry.core.packages.package import Package

from poetry.repositories.repository import Repository

class Pool(Repository):

class Pool:
def __init__(
self,
repositories: list[Repository] | None = None,
ignore_repository_names: bool = False,
) -> None:
super().__init__("poetry-pool")
self._name = "poetry-pool"

if repositories is None:
repositories = []
Expand All @@ -34,6 +35,10 @@ def __init__(

self._ignore_repository_names = ignore_repository_names

@property
def name(self) -> str:
return self._name

@property
def repositories(self) -> list[Repository]:
return self._repositories
Expand Down Expand Up @@ -128,9 +133,6 @@ def remove_repository(self, repository_name: str) -> Pool:

return self

def has_package(self, package: Package) -> bool:
raise NotImplementedError()

def package(
self,
name: str,
Expand Down

0 comments on commit 2d2ee7e

Please sign in to comment.