Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

poetry not recording hashes of modules from pypicloud server #1553

Closed
2 of 3 tasks
thehesiod opened this issue Nov 8, 2019 · 3 comments
Closed
2 of 3 tasks

poetry not recording hashes of modules from pypicloud server #1553

thehesiod opened this issue Nov 8, 2019 · 3 comments
Labels
kind/bug Something isn't working as expected

Comments

@thehesiod
Copy link

thehesiod commented Nov 8, 2019 •
edited
Loading

  • I am on the latest Poetry version.

  • I have searched the issues of this repo and believe that this is not a duplicate.

  • If an exception occurs when executing a command, I executed it again in debug mode (-vvv option).

  • OSX 10.15.1:

  • Poetry version: 1.0.0b3:

Issue

We have a pypi cloud server (https://github.com/stevearc/pypicloud) which doesn't return hashes of the files it stores. On it we have several .tar.gz sdist packages. Via pipenv it generates hashes for modules that it picks up from that server, but via poetry they're all missing hashes, ex:

fbn-aaa = []
fbn-bbb = []
fbn-ccc = []

seems like it's missing the codepath to download the module and generate a hash for the file it's going to lock to.
@thehesiod thehesiod added the kind/bug Something isn't working as expected label Nov 8, 2019
@thehesiod thehesiod mentioned this issue Nov 12, 2019
Closed
@thehesiod thehesiod mentioned this issue Apr 17, 2020
Merged
@leorochael
Copy link

This looks to be the same issue as #1631.

As of version 1.1.0, pypicloud does generate hashes for its links.

If you have a mass of packages without hashes, there are scripts for recalculating those hashes which should make pypicloud serve the hashes correctly for already uploaded packages:

https://github.com/stevearc/pypicloud/tree/master/scripts

abn added a commit to abn/poetry that referenced this issue Sep 25, 2020
@abn
repository/legacy: calculate sha256 if unavailable
37830c7 
In some cases, legacy repositories might not provide a checksum as a
url fragment or use a deprecated algorithm. In these scenarios, this
change ensures that poetry downloads and calculates the sha256 checksum
for the file.

Resolves: python-poetry#1631 python-poetry#1553
@abn abn mentioned this issue Sep 25, 2020
Merged
abn added a commit to abn/poetry that referenced this issue Sep 25, 2020
@abn
repository/legacy: calculate sha256 if unavailable
0b06d60 
In some cases, legacy repositories might not provide a checksum as a
url fragment or use a deprecated algorithm. In these scenarios, this
change ensures that poetry downloads and calculates the sha256 checksum
for the file.

Resolves: python-poetry#1631 python-poetry#1553
abn added a commit to abn/poetry that referenced this issue Mar 21, 2021
@abn
repository/legacy: calculate sha256 if unavailable
1eef86f 
In some cases, legacy repositories might not provide a checksum as a
url fragment or use a deprecated algorithm. In these scenarios, this
change ensures that poetry downloads and calculates the sha256 checksum
for the file.

Resolves: python-poetry#1631 python-poetry#1553
abn added a commit to abn/poetry that referenced this issue Mar 22, 2021
@abn
repository/legacy: calculate sha256 if unavailable
cd47280 
In some cases, legacy repositories might not provide a checksum as a
url fragment or use a deprecated algorithm. In these scenarios, this
change ensures that poetry downloads and calculates the sha256 checksum
for the file.

Resolves: python-poetry#1631 python-poetry#1553
kasteph pushed a commit that referenced this issue Mar 22, 2021
@abn @kasteph
repository/legacy: calculate sha256 if unavailable
3b340b2 
In some cases, legacy repositories might not provide a checksum as a
url fragment or use a deprecated algorithm. In these scenarios, this
change ensures that poetry downloads and calculates the sha256 checksum
for the file.

Resolves: #1631 #1553
@abn
Copy link
Member

abn commented Mar 22, 2021

Resolved-by: #2958

@abn abn closed this as completed Mar 22, 2021
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 2, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
kind/bug Something isn't working as expected
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@abn @leorochael @thehesiod