Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Private Repositories Fail Silently on Auth Errors #2576

Closed
3 tasks done
TimOrme opened this issue Jun 17, 2020 · 4 comments · Fixed by #2577
Closed
3 tasks done

Private Repositories Fail Silently on Auth Errors #2576

TimOrme opened this issue Jun 17, 2020 · 4 comments · Fixed by #2577
Labels
area/repo Meta-issues for the repository/forge itself area/ux Features and improvements related to the user experience
Milestone

Comments

@TimOrme
Copy link
Contributor

TimOrme commented Jun 17, 2020

  • I am on the latest Poetry version.
  • I have searched the issues of this repo and believe that this is not a duplicate.
  • If an exception occurs when executing a command, I executed it again in debug mode (-vvv option).

Issue

If using a private repository to install external dependencies, it currently fails silently if that private repository rejects the request due to authentication issues. It would be good to instead at least log a warning to inform the user that the server didn't accept the request. Otherwise, it seems to indicate a problem with the packages actually being present.

 % poetry add mypackage

[ValueError]
Could not find a matching version of package mypackage

If mypackage is only present in the private repo, but they don't have credentials set properly, it should indicate to the user that there was auth error on that repo.

@TimOrme TimOrme added kind/bug Something isn't working as expected status/triage This issue needs to be triaged labels Jun 17, 2020
@diogo-gaivota
Copy link

How did you know that it was authentication problem? I'm having a similar issue here, but even with -vvv, i hadn't any point on it.

@TimOrme
Copy link
Contributor Author

TimOrme commented Aug 5, 2020

I actually attached a debugger to discover it. I also added the PR here #2577 which adds logging for that case, so I was able to verify in that branch that the return status was 403.

@diogo-gaivota
Copy link

The problem is the same to me. I got an 401 that failed silently.

@finswimmer finswimmer added the area/repo Meta-issues for the repository/forge itself label Aug 6, 2020
@abn abn closed this as completed in #2577 Sep 24, 2020
abn pushed a commit that referenced this issue Sep 24, 2020
@abn abn added area/ux Features and improvements related to the user experience and removed status/triage This issue needs to be triaged kind/bug Something isn't working as expected labels Sep 24, 2020
@abn abn added this to the 1.1 milestone Sep 24, 2020
Copy link

github-actions bot commented Mar 3, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/repo Meta-issues for the repository/forge itself area/ux Features and improvements related to the user experience
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants