git repo with hypthens fails with error

[michael-c-hoffman]

• [ x] I am on the latest Poetry version.

• [x ] I have searched the issues of this repo and believe that this is not a duplicate.

• [ x] If an exception occurs when executing a command, I executed it again in debug mode (-vvv option).

• OS version and name: Fedora 34

• Poetry version: 1.1.5

• **Link of a Gist

Issue

When adding a git repo that includes a hyphen in the org/path poetry fails to add with an error:

TypeError

  expected string or bytes-like object

  at ~/.local/lib/python3.9/site-packages/poetry/core/utils/helpers.py:27 in canonicalize_name
       23│ _canonicalize_regex = re.compile(r"[-_]+")
       24│ 
       25│ 
       26│ def canonicalize_name(name):  # type: (str) -> str
    →  27│     return _canonicalize_regex.sub("-", name).lower()
       28│ 
       29│ 
       30│ def module_name(name):  # type: (str) -> str
       31│     return canonicalize_name(name).replace(".", "_").replace("-", "_")

[gabrielbdsantos]

I'm having the same issue on poetry 1.1.11.

poetry add --help gives poetry add git+https://github.com/python-poetry/poetry.git as an example, which is indeed a valid one. I have just tried it. However, when I try poetry add git+https://github.com/tpaviot/pythonocc-core.git, poetry throws that issue.

So, it seems that the problem is not with hyphens in general, but only in package names, right?

[michael-c-hoffman]

Correct

…

On Tue, Nov 2, 2021, 18:47 Gabriel B. Santos ***@***.***> wrote: I'm having the same issue on poetry 1.1.11. poetry add --help gives poetry add git+ https://github.com/python-poetry/poetry.git as an example, which is indeed a valid one. I have just tried it. However, when I try poetry add git+https://github.com/tpaviot/pythonocc-core.git, poetry throws that issue. So, it seems that the problem is not with hyphens in general, but only in the package names, right? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#4678 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAO7TKSIHEDPHJDEDKG5JC3UKBS67ANCNFSM5G2W36BQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[srikanthravipati]

poetry/poetry/puzzle/provider.py

Lines 309 to 311 in 5dcf24d

	package = PackageInfo.from_directory(path=directory).to_package(
	root_dir=directory
	)

to

    package = PackageInfo.from_directory(path=directory).to_package(
        name=name, root_dir=directory
    ) 

? so that name gets propagated correctly...

[michael-c-hoffman]

yes, I can confirm that this change fixes my issue.

[michael-c-hoffman]

can this get merged into the next release?

[neersighted]

can this get merged into the next release?

Hi @michael-c-hoffman -- I'm not aware of any outstanding PRs with this fix. A PR with the fix and a regression test would be welcomed, and I'd love to be pointed to an already-extant one if I missed it.

[michael-c-hoffman]

@neersighted I did not have a PR or code, this was just from comment that @srikanthravipati provided in the comments above. I am not familiar enough with this code base to write the tests.

[nathan-kairon]

I got the same issue

[abn]

I suspect the reported issue has been resolved with #5428 as the vay we create the directory was changed. This might also be a duplicate of #3392.

Can someone verify using poetry@master?

[neersighted]

@skairunner Could you please test your failing repo against current master?

[skairunner]

I am happy to confirm that poetry@master resolves this particular issue.

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.