Fix version union constraint not properly generated (non PEP508 compliant) #1767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomzx
force-pushed
the
fixes/version-union-constraint-pep-508-name
branch
from
b322601 to
26070a1
Compare
When we have a union of constraints, those were not properly generated. For example, ^1.2.3,!=1.3.5 would be converted to ^1.2.3,!=1.3.5 (same string) under PEP508, which is not valid.
tomzx
force-pushed
the
fixes/version-union-constraint-pep-508-name
branch
from
26070a1 to
e7c0ce2
Compare
|
Hello @tomzx , would be happy to review this PR. Can you rebase onto the current master please, to fix the conflicts? Thanks a lot your contribution! 👍 fin swimmer |
2 tasks
|
Hey @finswimmer, I've migrated the code over to I'll leave this issue open as a reminder to merge the |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we have a union of constraints, those were not properly generated.
For example,
^1.2.3,!=1.3.5would be converted to^1.2.3,!=1.3.5(samestring) under PEP508, which is not valid. This PR will instead produce
>1.2.3,<2.0.0,!=1.3.5.The approach may not be the best/cleanest, so I'm open to hear suggestions of improvements.
Thanks!
Note: Should fix #1522.
Pull Request Check List
Updated documentation for changed code.