Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing URL source option for multi-constraint dependencies #1819

Closed
wants to merge 2 commits into from
Closed

Fix missing URL source option for multi-constraint dependencies #1819

wants to merge 2 commits into from

Conversation

veloxo
Copy link

@veloxo veloxo commented Jan 3, 2020

Updated the schema to allow URL sources in multi-constraint dependencies. Looks like a minor oversight when url-dependencies were added in #1260.

  • Added tests for changed code.
  • Updated documentation for changed code. N/A

@GilZ
Copy link

GilZ commented Feb 6, 2020

Thanks! This PR fixes a real blocker I have, preventing me from installing pytorch on Linux & Windows. I hope it's going to be merged soon

Copy link
Member

@finswimmer finswimmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Thanks a lot for your contribution!

@finswimmer finswimmer added the kind/bug Something isn't working as expected label Feb 10, 2020
@sdispater
Copy link
Member

Thanks for your contribution!

However, #2035, which fixes the same issue, has already been merged. So I am closing this PR.

@sdispater sdispater closed this Feb 28, 2020
@eterna2
Copy link

eterna2 commented Apr 21, 2020

Thanks! This PR fixes a real blocker I have, preventing me from installing pytorch on Linux & Windows. I hope it's going to be merged soon

Hey @GilZ
did u ever managed to succeed in install pytorch in both windows and linux? Cuz I couldn't because of #2138

@veloxo veloxo deleted the fix-multi-constraints-add-url-dependency branch June 7, 2020 22:48
Copy link

github-actions bot commented Mar 1, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Something isn't working as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants