Respect develop when installing from git
#1986
Conversation
* fixes python-poetry#1080, again
fantix
force-pushed
the
fix_git_develop
branch
from
4398a35
to
789a00d
Compare
|
So why this PR has not been reviewed or merged for a month? I've been facing an issue which is not resolved without this PR so if any help is required, I'm really welcome to do. |
There was a problem hiding this comment.
Could you rebase your branch on develop?
I addressed some points that need changing but overall it looks good.
Also, some of the changes of you PR have been ported over to python-poetry/poetry-core#23 since some of the files modified by your PR have been moved to poetry-core.
| @@ -169,6 +169,7 @@ def search_for_vcs(self, dependency): # type: (VCSDependency) -> List[Package] | |||
| dependency.source, | |||
| dependency.reference, | |||
| name=dependency.name, | |||
| develop=dependency.develop, | |||
There was a problem hiding this comment.
This is not the right place to put this, get_package_from_vcs should not have any notion of develop.
So, similarly to what is done in search_for_directory, we can do:
package.develop = dependency.develop| cls, vcs, url, reference=None, name=None, develop=True, | ||
| ): # type: (str, str, Optional[str], Optional[str], Optional[bool]) -> Package |
| @@ -206,6 +207,7 @@ def get_package_from_vcs( | |||
| package.source_type = "git" | |||
| package.source_url = url | |||
| package.source_reference = revision | |||
| package.develop = develop | |||
|
Closing this as this is long stale and the issue has been solved in master/Poetry 1.2 beta for a long time. Please open a new issue/PR if you still observe broken behavior. |
|
@neersighted which commits the issue was addressed? |
|
f0855d9 and python-poetry/poetry-core@fc4ae2d If you are having trouble with this functionality, please open a new Discussion or join Discord. If you think you are experiencing a bug with it, please open an issue with steps for reproduction/your project files. |
|
Thank you for your quick reply!! |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
develop = falseoption when installing from git/http #1080, again