support git subfolder (#755) #2242
Conversation
…g properly new (poetry-schema): add subdirectory property to git-dependency new (pip_installer): git repositories are cloned to a tmp folder, to be able to copy only subdirectory to dest new (locker): write to and read from `poetry.lock` the subdirectory value new (provider): take the subdirectory value into account when looking for packing new (package): new property `source_subdirectory`
new (console.commands.init): git subdirectory can be provided in url when using `poetry add`
… multiple times from the same source during run
… method to work with python2
…ng confusion to poetries repository caching system change (utils.temp): renamed DownloadCache to DownloadTmpDir
fix (installed_repository): Catch CalledProcessError when trying to fetch revision
finswimmer
force-pushed
the
issue-0755-git-subdirectory-for-core
branch
from
826d9dc to
8fec715
Compare
fix (test_lock): comment out test that rely on changes in poetry_core
|
what is the status on this? Is there an E.T.A. ? |
|
Hello @pwhissell , we are still discussing how to test changes in fin swimmer |
|
Thank you for your quick resopnse @finswimmer |
|
In version 20.2.2, pip now supports this out of the box |
|
@finswimmer -- couldn't you push the changes to poetry core separately (with tests), and then push the rest afterwards? Don't let the bureaucracy get you down! :) |
|
@shaunc Yes and no :) If I want to go that way, the pushed code to core must also be released. Once this is released I could push the code the poetry. We have to find a better solution and I'm sure we will in the near future. We will run in this problem more often whenever a new feature is implemented in poetry. |
|
One solution over in javascript land is to use a monorepo, so that releases are automatically coordinated. That use case is supported, in part, by this very PR! :) |
|
Looking forward to this one. Solves a huge issue for me. |
|
Useful feature for monorepos that contain a collection of packages such as https://github.com/man-group/pytest-plugins |
|
Guys, any updates on this? |
|
I'm closing this PR and the related in python-poetry/poetry-core#9 for the following reasons:
|
|
@finswimmer If you specifically want to check for git subfolders, looking at submodules or subtrees is probably the right way to go |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This PR implements the possibility to add git dependencies, where the package is located within a subdirectory of the repository.
This was orginaly implemented in #1822, but needs rework due to the new poetry_core package.
Merging this PR requires merging of python-poetry/poetry-core#9 in poetry_core as well.
The path to the subdirectory can be specified as follows:
Where
pyproject-demois a subfolder relative to the root after checkout the repository. This can be combined with the revision tag:To specify the subdir in the
pyproject.tomla new argumentsubdirectorywas introduced:To implement this feature is was necessary to checkout the repository first to a temporary folder and copy the desired folder to it's destination. For this a new
DownloadTmpDirclass was implemented, which avoids downloading from the same git source multiple times, during run time.I would like to get some feed back from people, who can test this on a real world use case. Especially if this all works as expected.
Implements: #755
Pull Request Check List
This is just a reminder about the most common mistakes. Please make sure that you tick all appropriate boxes. But please read our contribution guide at least once, it will save you unnecessary review cycles!