-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a --parallel flag to the install command #2374
Conversation
Can of course not be merged since it |
Tested this on our production codebase by installing from scratch two times: Without this patch: 4 minutes and 22 seconds. Worked really well! |
👋 Hey folks, I just wanted to express explicit interest in this patch. Our initial install times are floating around ~15 minutes. In comparison Is there anything we can do to bump the priority of this PR? Thanks in advance! |
I don't think there is an explicit process for getting someone in the core team to look at a PR. For example, the uncontroversial PR #2375 has been waiting for review for a long time now. Myself, I am maintaining my own personal fork of Poetry with a couple of extra patches like this one. Would definitely prefer to merge something like this though. |
Hey @abn @finswimmer @sdispater @stephsamson, I'm explicitly raising your attention to this PR because I think it could really be beneficial for everyone. We recently switched to use Poetry and we do love it! However our install times went from ~4 minutes to ~15 minutes which is starting to become a serious issue for us. These 10 more minutes quickly add up and our deployment pipelines and developer environment (we use Docker locally) got badly impacted performance-wise. So now we're in this kind of situation where we do love the tool, but its performance is a big concern 😞 This PR cuts down install times by a factor of ~4 which is really a huge improvement 👏 . It seems that the change-set looks relatively straightforward, though I'm not an expert here. From my experience this kind of high-reward / low-risk PRs should be considered as high-priority since they don't involve that much time on the reviewer side. Is there anything @PetterS or I could do to move things forward and help this PR to get merged? |
Thanks for your contribution! There is an ongoing work (see develop...new-installer), to allow for parallel installations (with UI improvements to go with it) and other installation improvements, for instance downloading distributions separately. The ultimate goal is to no longer rely on pip for the installation. This will land in the next feature release as an experimental feature (activated with |
That's nice! |
Closing this PR since the PR for the new installer is now ready #2595 Thanks again for your contribution! |
Looks really great! |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Tested this on our production codebase by installing from scratch two times:
Without this patch: 4 minutes and 22 seconds.
With --parallel: 1 minute and 8 seconds.