Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add humble retry logic for package downloads #2813

Merged
merged 1 commit into from
Aug 29, 2020

Conversation

abn
Copy link
Member

@abn abn commented Aug 15, 2020

Resolves: #2736

@abn abn requested a review from a team August 15, 2020 16:19
@abn abn force-pushed the installation-retry-logic branch from dac1573 to 2f73c4d Compare August 15, 2020 16:26
@abn abn force-pushed the installation-retry-logic branch from 2f73c4d to 0e20355 Compare August 15, 2020 16:33
Copy link
Member

@finswimmer finswimmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@finswimmer finswimmer merged commit c22052c into python-poetry:master Aug 29, 2020
@abn abn mentioned this pull request Aug 29, 2020
@sdispater sdispater mentioned this pull request Sep 18, 2020
@abn abn deleted the installation-retry-logic branch October 6, 2020 22:03

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great to be able to override retries limit and HTTP statuses via configuration options.

Copy link

github-actions bot commented Mar 3, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a graceful retry logic for intermittent network failure when downloading packages
3 participants