Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle (*) constraint for pre-release only packages #2821

Merged
merged 1 commit into from
Aug 27, 2020

Conversation

abn
Copy link
Member

@abn abn commented Aug 17, 2020

This change ensures that packages that only have a pre-release versions
are pragmatically discovered via find_packages when a constraint (*)
is specified.

Resolves: #2819

Pull Request Check List

  • Added tests for changed code.

@abn abn requested a review from a team August 17, 2020 16:33
This change ensures that packages that only have a pre-release versions
are pragmatically discovered via `find_packages` when a constraint (*)
is specified.

Resolves: python-poetry#2819
Copy link
Member

@finswimmer finswimmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

As this change would change behavior I let it to @sdispater to merge it.

@finswimmer finswimmer requested a review from sdispater August 18, 2020 04:47
@abn abn added the kind/bug Something isn't working as expected label Aug 27, 2020
@abn
Copy link
Member Author

abn commented Aug 27, 2020

Merging this for now. We can revert it later if this causes issues.

@abn abn merged commit b2b9075 into python-poetry:master Aug 27, 2020
@abn abn deleted the issues/2819 branch August 27, 2020 14:35
@sdispater sdispater mentioned this pull request Sep 18, 2020
Copy link

github-actions bot commented Mar 1, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Something isn't working as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SolverProblemError with papermill
2 participants