-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
locker: move export logic into locker for reuse #3119
Merged
Merged
Commits on Oct 13, 2020
-
locker: move export logic into locker for reuse
This change, moves common functionality from exporter into the locker to allow for sharing of logic that can generate `DependencyPackage` instances given a a list of requirements using the lock data.
Configuration menu - View commit details
-
Copy full SHA for 8b67d16 - Browse repository at this point
Copy the full SHA 8b67d16View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9854506 - Browse repository at this point
Copy the full SHA 9854506View commit details -
locker: propagate cumulative markers to nested deps
This change ensures that markers are propagated from top level dependencies to the deepest level by walking top to bottom instead of iterating over all available packages. In addition, we also compress any dependencies with the same name and constraint to provide a more concise representation. Resolves: python-poetry#3112 #3160
Configuration menu - View commit details
-
Copy full SHA for 48caa17 - Browse repository at this point
Copy the full SHA 48caa17View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8bc93d9 - Browse repository at this point
Copy the full SHA 8bc93d9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 665afb8 - Browse repository at this point
Copy the full SHA 665afb8View commit details -
locker: ensure correct handling of extras export
Previously, when determining nested dependencies, the check for activated extras/features of top level dependencies were done after the nested dependencies were processed. This lead to exports containing in active extras. This change resolves this by pre-selecting top level packages prior to identifying nested dependencies.
Configuration menu - View commit details
-
Copy full SHA for 410df99 - Browse repository at this point
Copy the full SHA 410df99View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6edf15f - Browse repository at this point
Copy the full SHA 6edf15fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 36d74ae - Browse repository at this point
Copy the full SHA 36d74aeView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.