Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport caching improvements to 1.1 branch #6129

Conversation

maksbotan
Copy link
Contributor

Pull Request Check List

This backports #4618 #2398 to 1.1 branch to fix related issues.

  • Added tests for changed code.
  • Updated documentation for changed code.

I took liberty to skip updating tests.

This is essentially a backport of
b06658f plus some typing improvements.
This synchronizes code with master, and also adds more typings.
@maksbotan maksbotan force-pushed the maksbotan/backport-caching-improvements branch from 384ab5a to aac4b2b Compare August 7, 2022 19:49
@maksbotan
Copy link
Contributor Author

CI seems to fail for reasons not related to my changes 🤔

@Secrus
Copy link
Member

Secrus commented Aug 9, 2022

Hi. First of all, thank you for contributing to Poetry. However, since we are focusing on the 1.2 release, we won't be doing any more releases of version 1.1 (unless there are some breaking changes in 3rd party APIs like it was with 1.1.14). Backporting changes to an old version makes little sense since it probably will never be released.

@maksbotan
Copy link
Contributor Author

Thanks for the response! I'll stick with poetry-core from my git branch at work for now, as this speedup is critical for us. Combined, my four pull requests drop poetry lock --no-update from 7 minutes to just 3 seconds.

What is the release schedule for 1.2 branch? And can you please review my PRs that add new improvements to master?

Thanks.

@neersighted
Copy link
Member

Thanks for the response! I'll stick with poetry-core from my git branch at work for now, as this speedup is critical for us. Combined, my four pull requests drop poetry lock --no-update from 7 minutes to just 3 seconds.

What is the release schedule for 1.2 branch? And can you please review my PRs that add new improvements to master?

Thanks.

#5586

We're working on catching up on reviews, but the last month has seen most of the team dealing with IRL priorities including health, work, and family -- we're still committed to getting this release out as soon as we are able, and to much smaller releases in the future to avoid similar pain.

@maksbotan
Copy link
Contributor Author

Thanks! I've subscribed to that thread.

@Secrus
Copy link
Member

Secrus commented Aug 16, 2022

I will close this to reduce noise in PRs

@Secrus Secrus closed this Aug 16, 2022
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants