Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify removal for non-installed extras & optional groups (#6229) #6432

Merged
merged 2 commits into from
Sep 12, 2022

Conversation

chimaerase
Copy link
Contributor

Pull Request Check List

Resolves: #6229

  • Added tests for changed code.
  • Updated documentation for changed code.

I haven't exhaustively verified claims made in these very simple documentation additions, but tried to keep them limited in scope to my personal experience with 1.2. Hopefully they are quite easy to review by someone more familiar with the project. If nothing else, this is a straw man example of the type of additions I would find helpful.

@chimaerase
Copy link
Contributor Author

pre-commit.ci autofix

@Secrus Secrus added area/docs Documentation issues/improvements impact/docs Contains or requires documentation changes labels Sep 7, 2022
@github-actions
Copy link

github-actions bot commented Sep 7, 2022

Deploy preview for website ready!

✅ Preview
https://website-b7t92qdd8-python-poetry.vercel.app

Built with commit e5cd834.
This pull request is being automatically deployed with vercel-action

@neersighted neersighted added impact/backport Requires backport to stable branch backport/1.2 labels Sep 12, 2022
@neersighted neersighted merged commit 06e61fa into python-poetry:master Sep 12, 2022
@poetry-bot
Copy link

poetry-bot bot commented Sep 12, 2022

The backport to 1.2 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.2 1.2
# Navigate to the new working tree
cd .worktrees/backport-1.2
# Create a new branch
git switch --create backport-6432-to-1.2
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 06e61fae04320eb24f4132452ee6f20e3e9049a2
# Push it to GitHub
git push --set-upstream origin backport-6432-to-1.2
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.2

Then, create a pull request where the base branch is 1.2 and the compare/head branch is backport-6432-to-1.2.

Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/docs Documentation issues/improvements impact/backport Requires backport to stable branch impact/docs Contains or requires documentation changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Install removes dependencies of non-installed extras
3 participants