Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for pyproject with multiple readme files #6678

Conversation

wagnerluis1982
Copy link
Contributor

@wagnerluis1982 wagnerluis1982 commented Oct 2, 2022

Pull Request Check List

tests/masonry/builders/test_editable_builder.py

  • Checks if content of all readme files are printed to the metadata

tests/console/commands/test_build.py (new file)

  • Checks sdist file exists and is not empty
  • Checks wheel file exists and is not empty
  • Checks inside sdist tar file if contains all readme files

Closes: #6633
Depends on: python-poetry/poetry-core#551

  • This PR only add tests

@wagnerluis1982
Copy link
Contributor Author

Question to maintainers, does poetry have any integration test for poetry build command? I was not able to found any.

@radoering
Copy link
Member

Probably not. (It should be located at tests/console/commands.)

Since the test in this PR is passing even without the poetry-core fix, I assume an integration test is required to provoke the issue?

@wagnerluis1982
Copy link
Contributor Author

@radoering Exactly, that's why I was looking for an integration test for build.

I will create a new test module then.

@wagnerluis1982 wagnerluis1982 force-pushed the add-tests-pyproject-with-multiple-readme-files branch from 5247531 to c83a344 Compare October 3, 2022 22:23
@wagnerluis1982 wagnerluis1982 marked this pull request as ready for review October 3, 2022 22:23
@wagnerluis1982
Copy link
Contributor Author

Just added a test to verify poetry build command.

NOTE: the pipeline is going to fail until python-poetry/poetry-core#486 is merged.

@wagnerluis1982
Copy link
Contributor Author

Hi @radoering, after you merged python-poetry/poetry-core#486, I expected the tests to not fail (I just rebased after master).

I expected the pipeline to use latest poetry-core version. Does that happen?

@radoering
Copy link
Member

No, it just uses the locked version of poetry-core (no magic). Normally, we just update the locked version after a core release.

@wagnerluis1982
Copy link
Contributor Author

No, it just uses the locked version of poetry-core (no magic). Normally, we just update the locked version after a core release.

No magic 🙁

In that case, it would be advisable to reopen issue #6633 to signalize users, IMHO.

@radoering radoering mentioned this pull request Jan 15, 2023
@wagnerluis1982 wagnerluis1982 force-pushed the add-tests-pyproject-with-multiple-readme-files branch from d920f72 to 124f677 Compare January 21, 2023 16:14
@wagnerluis1982
Copy link
Contributor Author

@Secrus the tests here are going to fail while next poetry-core isn't released.

@wagnerluis1982 wagnerluis1982 force-pushed the add-tests-pyproject-with-multiple-readme-files branch from eddc5ee to ccaf3bc Compare January 31, 2023 21:33
@wagnerluis1982
Copy link
Contributor Author

@radoering when you have a chance, please check this.

Now that poetry-core 1.5.0 is locked, the tests are passing.

Copy link
Member

@radoering radoering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor nitpicks.

tests/masonry/builders/test_editable_builder.py Outdated Show resolved Hide resolved
tests/fixtures/with_multiple_readme_files/pyproject.toml Outdated Show resolved Hide resolved
@radoering radoering merged commit 98568d4 into python-poetry:master Feb 3, 2023
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

poetry build fails sdist build when using multiple readme entries
2 participants