-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: update setuptools/wheel first before other (parallel) installs #7701
Conversation
Why? Normally, setuptools in the target environment shouldn't be relevant because of poetry/src/poetry/utils/pip.py Line 38 in 71b3d6e
|
I added the missing issue in the description, eg: Resolves: #7046 |
If a package is build from source because no pep517 build system are indicated in pyproject.toml or the file is missing, pep517 will fallback to setuptools and wheel installed within the virtualenv to build it. eg: https://github.com/pypa/pip/blob/22.3.1/src/pip/_vendor/pep517/wrappers.py#L167 https://github.com/pypa/pip/blob/22.3.1/src/pip/_vendor/pep517/wrappers.py#L220 https://github.com/pypa/pip/blob/22.3.1/src/pip/_vendor/pep517/wrappers.py#L273 Fixes python-poetry#7046
What is the minimal version of pip poetry support? Because it looks like the build-system fallback has been dropped in 23.0. |
I still don't understand what the connection is between the installation of Surely they are completely different |
I continue to dig, and I don't get it either. The interesting logs are:
I was misled by this, and as you seem to confirm, this is unrelated to the issue we see later in the logs. Then pip fails:
I'm going to close this PR. |
I could just about believe an explanation that said that pip somehow re-uses the nearest However I've no reason to think that's true, it's pure speculation. If you're hitting the issue frequently enough that this is worth your trouble, perhaps you can also test the change to see whether - experimentally - it seems to help or not. |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
If a package is build from source because no pep517 build system are
indicated in pyproject.toml or the file is missing, pep517 will fallback
to setuptools and wheel installed within the virtualenv to build it.
eg:
https://github.com/pypa/pip/blob/22.3.1/src/pip/_vendor/pep517/wrappers.py#L167
https://github.com/pypa/pip/blob/22.3.1/src/pip/_vendor/pep517/wrappers.py#L220
https://github.com/pypa/pip/blob/22.3.1/src/pip/_vendor/pep517/wrappers.py#L273
Resolves: #7046