Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix generate_system_pyproject newline issues #7705

Merged
merged 10 commits into from
Mar 27, 2023
Merged

Fix generate_system_pyproject newline issues #7705

merged 10 commits into from
Mar 27, 2023

Commits on Mar 22, 2023

  1. Implemented fixes and added tests

    @NimajnebEC
    NimajnebEC committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    2ef7d6d View commit details
    Browse the repository at this point in the history

  2. Removed newline kwarg from test 

    Removed newline kwarg from cmd.system_pyproject.write_text call in tests for compatibility with older versions.
    @brooke-ec
    brooke-ec authored Mar 22, 2023
    Configuration menu
    Copy the full SHA
    c233715 View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2023

  1. Use TOMLFile.write for saving and remove newline

    @NimajnebEC
    NimajnebEC committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    05ba928 View commit details
    Browse the repository at this point in the history

  2. Implemented fixes and added tests

    @NimajnebEC @brooke-ec
    NimajnebEC authored and brooke-ec committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    09094f0 View commit details
    Browse the repository at this point in the history

  3. Removed newline kwarg from test 

    Removed newline kwarg from cmd.system_pyproject.write_text call in tests for compatibility with older versions.
    @brooke-ec
    brooke-ec committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    c46fb4f View commit details
    Browse the repository at this point in the history

  4. Use TOMLFile.write for saving and remove newline

    @NimajnebEC @brooke-ec
    NimajnebEC authored and brooke-ec committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    523faba View commit details
    Browse the repository at this point in the history

  5. Merge branch 'fix-generate-system-pyproject-newlines' of https://gith… 

    …ub.com/NimajnebEC/poetry into fix-generate-system-pyproject-newlines
    @NimajnebEC
    NimajnebEC committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    3015cc3 View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2023

  1. Apply suggestions from code review 

    Co-authored-by: Randy Döring <30527984+radoering@users.noreply.github.com>
    @brooke-ec @radoering
    brooke-ec and radoering authored Mar 26, 2023
    Configuration menu
    Copy the full SHA
    ac692d1 View commit details
    Browse the repository at this point in the history

  2. Remove path parameter and rename test file

    @NimajnebEC
    NimajnebEC committed Mar 26, 2023
    Configuration menu
    Copy the full SHA
    bc62304 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'fix-generate-system-pyproject-newlines' of https://gith… 

    …ub.com/NimajnebEC/poetry into fix-generate-system-pyproject-newlines
    @NimajnebEC
    NimajnebEC committed Mar 26, 2023
    Configuration menu
    Copy the full SHA
    65ce8f3 View commit details
    Browse the repository at this point in the history