Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config)!: change virtualenvs.prefer-active-python default to true #9786

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

finswimmer
Copy link
Member

virtualenvs.prefer-active-python was introduced in 1.2 and works well since than. So there is no need to call it "experimental" any longer (even if there might be space for some improvements).

@finswimmer finswimmer marked this pull request as ready for review October 20, 2024 11:45
@finswimmer finswimmer added the area/docs Documentation issues/improvements label Oct 20, 2024
@finswimmer finswimmer requested a review from a team October 20, 2024 11:46
@Secrus
Copy link
Member

Secrus commented Oct 20, 2024

I was actually considering if we could remove that option or invert it so that one can choose to use system Python instead of the active one. That seems more instinctive behaviour than what we have currently

@finswimmer
Copy link
Member Author

I was actually considering if we could remove that option or invert it

I wouldn't remove it, but inverting the default would be fine (But I'm biased here, because that's the config I change first in an new installation ;)

@finswimmer finswimmer changed the title docs: virtualenvs.prefer-active-python no longer experimental feat(config)!: change virtualenvs.prefer-active-python default to true Oct 20, 2024
@finswimmer finswimmer added this to the Poetry 2.0 milestone Oct 20, 2024
@Secrus
Copy link
Member

Secrus commented Oct 20, 2024

Well, we could take advantage of the fact that we are making a breaking release and change that to use-system-python that would force usage of the Python version Poetry was installed with. That would give us an open interface to introduce findpython backend without breaking changes but as an alternative (until deemed stable).

@finswimmer
Copy link
Member Author

I'm fine with renaming, but I think use-system-python is confusing for the users. While it is consistent with the code base, I guess most users would expect that the Python of their system is meant. Maybe use-application-python or use-poetry-python?

@Secrus
Copy link
Member

Secrus commented Oct 25, 2024

I'm fine with renaming, but I think use-system-python is confusing for the users. While it is consistent with the code base, I guess most users would expect that the Python of their system is meant. Maybe use-application-python or use-poetry-python?

I am fine with use-poetry-python and a proper docs entry explaining that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs Documentation issues/improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants