Update tests action #357
Merged
Update tests action #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
waketzheng
commented
Jun 4, 2024
waketzheng
commented
- Update cache action version
- Remove quotes around 3.11
- Use map to replace list comprehension
frostming
reviewed
Jun 4, 2024
| @@ -34,7 +34,7 @@ jobs: | |||
| id: full-python-version | |||
| shell: bash | |||
| run: | | |||
| echo ::set-output name=version::$(python -c "import sys; print('-'.join(str(v) for v in sys.version_info))") | |||
There was a problem hiding this comment.
Can you change this to the new GITHUB_OUTPUT syntax?
There was a problem hiding this comment.
Do you mean: echo "{name}={value}" >> "$GITHUB_OUTPUT"?
frostming
reviewed
Jun 4, 2024
.github/workflows/tests.yml
Outdated
| @@ -34,7 +34,7 @@ jobs: | |||
| id: full-python-version | |||
| shell: bash | |||
| run: | | |||
| echo ::set-output name=version::$(python -c "import sys; print('-'.join(str(v) for v in sys.version_info))") | |||
| echo name=version::$(python -c "import sys; print('-'.join(map(str, sys.version_info)))") >> "$GITHUB_OUTPUT" | |||
There was a problem hiding this comment.
Suggested change
| echo name=version::$(python -c "import sys; print('-'.join(map(str, sys.version_info)))") >> "$GITHUB_OUTPUT" | |
| echo version=$(python -c "import sys; print('-'.join(map(str, sys.version_info)))") >> "$GITHUB_OUTPUT" |
frostming
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.