-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: flask import of _endpoint_from_view_func - issue #567 #572
Conversation
…l function import_check_view_func python-restx#567
Thanks for doing this @Ryu-CZ I'm assuming this is held up by the |
@peter-doggart yes, tests are not passing because |
…ice static checks
I forgot to add my method into |
Still waiting on the pytest fixes, but it looks like they are working on getting that project updated. :) |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #572 +/- ##
==========================================
- Coverage 96.45% 96.15% -0.30%
==========================================
Files 20 20
Lines 2733 2755 +22
==========================================
+ Hits 2636 2649 +13
- Misses 97 106 +9
☔ View full report in Codecov by Sentry. |
I forget to mention the new method |
Due to repeated accident of import error #567 I added helper method import_check_view_func . With fallback to last known implementation which stayed the same in all flask versions.
I submit new pull request with new branch name
flask-scaffold_567
on same commit, because in original pull request #568 I usedmaster
branch in contrary to guidelines.