Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meta-tests #14

Merged
merged 1 commit into from
Jul 29, 2022
Merged

Meta-tests #14

merged 1 commit into from
Jul 29, 2022

Conversation

jakkdl
Copy link
Member

@jakkdl jakkdl commented Jul 29, 2022

Fixes #13

Also found what I think is a bug in TRIO100, and added TRIO106 to README.md

Copy link
Member

@Zac-HD Zac-HD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice ✅

Quick style note, if you're comfortable with pytest-style test functions I'm just as happy to use those as unittest classes.

@Zac-HD Zac-HD merged commit 18a0d29 into python-trio:main Jul 29, 2022
@jakkdl
Copy link
Member Author

jakkdl commented Jul 30, 2022

I haven't used either extensively enough to have too much of an opinion - but I needed access to a msg parameter to give more info and the first place I looked that had it was unittest.

Even better would be to have multiple different tests generated for each file, instead of it quitting on the first file/test pair that fails, but didn't bother spending time on figuring out how to do that.

@Zac-HD
Copy link
Member

Zac-HD commented Jul 30, 2022

assert condition, "message" is the pytest idiom fyi 🙂

Agree that it's not worth extending further though!

@jakkdl
Copy link
Member Author

jakkdl commented Jul 30, 2022

Thank you, good to know!

@jakkdl jakkdl deleted the meta-tests branch December 9, 2022 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

meta-tests
2 participants