10: add trio[301], don't await trio.sleep inside loop #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In order to stick to cases where Event really does seem better, I'd confine this check specifically to while-loops, and only where |
|
Ah, fixed! |
Zac-HD
force-pushed
the
10_no_trio_sleep_in_loop
branch
from
8888019 to
ea669fb
Compare
Zac-HD
force-pushed
the
10_no_trio_sleep_in_loop
branch
from
ea669fb to
3d8fdf4
Compare
|
Nice! Straightforward as you say, modulo some brain-fog-inspired complications merging several PRs in a row 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Straightforward stuff. Made it also check [async] for, and to specifically only check "trio.sleep"